-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Important! Template update for nf-core/tools v3.0.2 #545
Conversation
|
A full test was run locally and it passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to make a few broken samplesheets and upload to the test-data repo so we can double check the schema is working like I did here: nf-core/test-datasets#1350
Did you also check that all our meta condition checks like meta.<xxx> == null
or !meta.<xxx>
for optional meta fields are OK, and tags look OK, no random []
empty strings, given https://nfcore.slack.com/archives/C056RQB10LU/p1729069030926369?
I
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! I just need to fix the test requirements in the repo settings :)
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@nf-core-bot fix linting |
Added broken samplesheets and databases to test input and database schema nf-core/test-datasets#1357 |
Version
3.0.2
of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the
nf-core-template-merge-3.0.2
branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.
For more information about this release of nf-core/tools, please see the
v3.0.2
release page.