Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createtaxdb: add broken samplesheets #1350

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Oct 17, 2024

No description provided.

Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Where will this be tested?

@jfy133
Copy link
Member Author

jfy133 commented Oct 17, 2024

Manually for now, but if I work out a nice way (with nf-test maybe) can add that in the future

@jfy133 jfy133 merged commit 80c00f5 into nf-core:createtaxdb Oct 17, 2024
@nvnieuwk
Copy link

Allright, I'll probably add them to the nf-schema tests themselves then if you are okay with that :p

@jfy133
Copy link
Member Author

jfy133 commented Oct 17, 2024

Allright, I'll probably add them to the nf-schema tests themselves then if you are okay with that :p

Go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants