Skip to content

Commit

Permalink
apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
mirpedrol committed Feb 15, 2024
1 parent 7f7e920 commit 28c0196
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion nf_core/create.py
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,6 @@ def fix_linting(self):
# Add the lint content to the preexisting nf-core config
config_fn, nf_core_yml = nf_core.utils.load_tools_config(self.outdir)
nf_core_yml["lint"] = lint_config
print("added linting config")
with open(self.outdir / config_fn, "w") as fh:
yaml.dump(nf_core_yml, fh, default_flow_style=False, sort_keys=False)

Expand Down
5 changes: 1 addition & 4 deletions nf_core/lint/files_exist.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,12 @@ def files_exist(self) -> Dict[str, Union[List[str], bool]]:
Path("lib", "Checks.groovy"),
Path("lib", "Completion.groovy"),
Path("lib", "Workflow.groovy"),
]
files_warn_ifexists = [
Path(".travis.yml"),
Path("lib", "NfcoreTemplate.groovy"),
Path("lib", "Utils.groovy"),
Path("lib", "WorkflowMain.groovy"),
Path("lib", "NfcoreTemplate.groovy"),
Path("lib", f"Workflow{short_name[0].upper()}{short_name[1:]}.groovy"),
]
files_warn_ifexists = [Path(".travis.yml")]
files_fail_ifinconfig: List[Tuple[Path, Dict[str, str]]] = [
(Path("lib", "nfcore_external_java_deps.jar"), {"plugins": "nf-validation"}),
]
Expand Down
4 changes: 2 additions & 2 deletions nf_core/pipeline-template/workflows/pipeline.nf
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ workflow {{ short_name|upper }} {
)

emit:
multiqc_report = MULTIQC.out.report // channel: /path/to/multiqc_report.html
versions = ch_versions // channel: [ path(versions.yml) ]
multiqc_report = MULTIQC.out.report.toList() // channel: /path/to/multiqc_report.html
versions = ch_versions // channel: [ path(versions.yml) ]
}

/*
Expand Down

0 comments on commit 28c0196

Please sign in to comment.