Merge pull request #2061 from mirpedrol/git-urls

allow other urls not starting with http
nf-core · Nov 28, 2022 · 74f7423 · 74f7423
2 parents fff7bea + f20e34d
commit 74f7423
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -38,6 +38,7 @@
 - Substitute ModulesCommand and SubworkflowsCommand by ComponentsCommand ([#2000](https://github.com/nf-core/tools/pull/2000))
 - Don't print source file + line number on logging messages (except when verbose) ([#2015](https://github.com/nf-core/tools/pull/2015))
 - Extended the chat notifications to Slack ([#1829](https://github.com/nf-core/tools/pull/1829))
+- Allow other remote URLs not starting with `http` ([#2061](https://github.com/nf-core/tools/pull/2061))
 
 ### Modules
 

diff --git a/nf_core/modules/modules_json.py b/nf_core/modules/modules_json.py
@@ -478,7 +478,12 @@ def has_git_url_and_modules(self):
             elif (
                 not isinstance(repo_url, str)
                 or repo_url == ""
-                or not repo_url.startswith("http")
+                or not (
+                    repo_url.startswith("http")
+                    or repo_url.startswith("ftp")
+                    or repo_url.startswith("ssh")
+                    or repo_url.startswith("git")
+                )
                 or not isinstance(repo_entry["modules"], dict)
                 or repo_entry["modules"] == {}
             ):