Skip to content

Commit

Permalink
warn instead of fail when no components are installed from the repo
Browse files Browse the repository at this point in the history
  • Loading branch information
mirpedrol committed Jan 22, 2024
1 parent faf8529 commit b2a4ca3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions nf_core/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ def lint(

# Run the lint tests!
try:
lint_obj, module_lint_obj = run_linting(
lint_obj, module_lint_obj, subworkflow_lint_obj = run_linting(
dir,
release,
fix,
Expand All @@ -613,7 +613,7 @@ def lint(
json,
ctx.obj["hide_progress"],
)
if len(lint_obj.failed) + len(module_lint_obj.failed) > 0:
if len(lint_obj.failed) + len(module_lint_obj.failed) + len(subworkflow_lint_obj.failed) > 0:
sys.exit(1)
except AssertionError as e:
log.critical(e)
Expand Down
4 changes: 1 addition & 3 deletions nf_core/components/lint/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ def __init__(
)
)
if not self.all_remote_components:
raise LookupError(
f"No {self.component_type} from {self.modules_repo.remote_url} installed in pipeline."
)
log.warning(f"No {self.component_type} from {self.modules_repo.remote_url} installed in pipeline.")
local_component_dir = Path(self.dir, self.component_type, "local")
self.all_local_components = []
if local_component_dir.exists():
Expand Down

0 comments on commit b2a4ca3

Please sign in to comment.