Skip to content

Commit

Permalink
Remove the corresponding pytest
Browse files Browse the repository at this point in the history
Also remove the pre-commit test about filenames, as it fails with majority of test files.
  • Loading branch information
ewels committed Nov 25, 2022
1 parent 66882cc commit d004a24
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 19 deletions.
5 changes: 0 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,3 @@ repos:
rev: "v2.6.2"
hooks:
- id: prettier
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: "v4.3.0"
hooks:
- id: name-tests-test
args: [--pytest-test-first]
13 changes: 0 additions & 13 deletions tests/lint/actions_ci.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,6 @@ def test_actions_ci_fail_wrong_nf(self):
assert results["failed"] == ["Minimum pipeline NF version '1.2.3' is not tested in '.github/workflows/ci.yml'"]


def test_actions_ci_fail_wrong_docker_ver(self):
"""Lint test: actions_actions_ci - FAIL - wrong pipeline version used for docker commands"""

self.lint_obj._load()
self.lint_obj.nf_config["process.container"] = "'nfcore/tools:0.4'"
results = self.lint_obj.actions_ci()
assert results["failed"] == [
"CI is not building the correct docker image. Should be: `docker build --no-cache . -t nfcore/tools:0.4`",
"CI is not pulling the correct docker image. Should be: `docker pull nfcore/tools:dev`",
"CI is not tagging docker image correctly. Should be: `docker tag nfcore/tools:dev nfcore/tools:0.4`",
]


def test_actions_ci_fail_wrong_trigger(self):
"""Lint test: actions_actions_ci - FAIL - workflow triggered incorrectly, NF ver not checked at all"""

Expand Down
1 change: 0 additions & 1 deletion tests/test_lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ def test_sphinx_md_files(self):
test_actions_awstest_pass,
)
from .lint.actions_ci import (
test_actions_ci_fail_wrong_docker_ver,
test_actions_ci_fail_wrong_nf,
test_actions_ci_fail_wrong_trigger,
test_actions_ci_pass,
Expand Down

0 comments on commit d004a24

Please sign in to comment.