Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu-latest will soon point to the next major Ubuntu version #2044

Closed
fabianegli opened this issue Nov 23, 2022 · 4 comments
Closed

ubuntu-latest will soon point to the next major Ubuntu version #2044

fabianegli opened this issue Nov 23, 2022 · 4 comments

Comments

@fabianegli
Copy link
Contributor

fabianegli commented Nov 23, 2022

Description of feature

ubuntu-latest is currently pointing to Ubuntu 20.04 but will very soon point to 22.04. See: https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/

If it is deemed necessary to support Ubuntu-20.04 we might want to parametrize the runs-on in the near future:
runs-on: [ubuntu-20.04, ubuntu-latest] or runs-on: [ubuntu-20.04, ubuntu-22.04]

Found the blog post while looking into #2043.

@Aratz
Copy link
Contributor

Aratz commented Nov 24, 2022

Good point!

I think it is really important that we test both versions, although I'm also thinking testing the whole matrix Python versions X Ubuntu versions might be a bit too heavy.

If that's possible maybe it would be preferable to only test [python-3.7, python-3.11] X [ubuntu-20.04, ubuntu-22.04] on dev and pull requests, and only test the full matrix when making a new release? Not sure if it is possible to implement this behavior in a nice way in GitHub workflows 🤔

@maxulysse
Copy link
Member

I think the only way to do so is to have a separate yml for release than the one for the regular tests

@fabianegli
Copy link
Contributor Author

fabianegli commented Nov 24, 2022

I mean, one could use ifs in the workflow yamls to skip undesired tests, but it might be more desirable to have a separate yaml for release and dev. See https://docs.github.com/en/actions/learn-github-actions/expressions, https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution and https://docs.github.com/en/actions/learn-github-actions/contexts#matrix-context.

@fabianegli
Copy link
Contributor Author

Or even specify a matrix in json format and load that: https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson

Aratz added a commit to Aratz/nf-core-tools that referenced this issue Nov 25, 2022
@Aratz Aratz closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants