Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker UID Defaults #336

Closed
apeltzer opened this issue May 16, 2019 · 12 comments
Closed

Docker UID Defaults #336

apeltzer opened this issue May 16, 2019 · 12 comments
Labels
template nf-core pipeline/component template
Milestone

Comments

@apeltzer
Copy link
Member

apeltzer commented May 16, 2019

We should probably think about adding this here as default to the Docker scope:

docker.enabled = true
fixOwnership = true
runOptions = "-u \$(id -u):\$(id -g)"
@apeltzer apeltzer added the template nf-core pipeline/component template label May 16, 2019
@apeltzer apeltzer added this to the 1.7 milestone May 16, 2019
@matq007
Copy link
Member

matq007 commented May 16, 2019

Also, most of the clusters are cunning CentOS which requires z parameter as well for docker.
mountFlags = 'z'

@apeltzer
Copy link
Member Author

apeltzer commented May 17, 2019

Do you guys use Docker on a cluster? We cannot do that for "security reasons" here. Also, does that then work for everyone? I know that the fixOwnership and runOptions stuff will work pretty much everywhere (?) while the mountFlags might not (?)

@matq007
Copy link
Member

matq007 commented May 17, 2019

We have isolated cluster where we have a docker. We are using local executor and the only way to actually run it correctly (CentOS security policy) I had to enable the mountFlags to z. It is also mentioned in the docs of nextflow.

@ewels
Copy link
Member

ewels commented May 18, 2019

I don't think that it should go in the template base config unless it works for everyone (at least, doesn't break stuff for those that don't need it). But why does nextflow itself not have these as defaults if that's the case?

@apeltzer
Copy link
Member Author

Good question - @pditommaso can you share some insights on why this is not the "default" behaviour?

@pditommaso
Copy link

Good point, that was planned nextflow-io/nextflow#515. It was never merged because it could introduce a breaking change caused by the fact that -u alters the user HOME variable, tho rarely it could be a problem.

Maybe it's time to give it a try.

@gongyixiao
Copy link

it could introduce a breaking change caused by the fact that -u alters the user HOME variable, tho rarely it could be a problem.

This causes problem when running Spark in Docker.
nextflow-io/nextflow#515 (comment)

@ewels
Copy link
Member

ewels commented Oct 5, 2019

runOptions added to the template in #352

fixOwnership isn't added (yet) - does that need to be there as well?

@apeltzer
Copy link
Member Author

apeltzer commented Oct 6, 2019

I think not no

@maxulysse
Copy link
Member

How important is it to keep this runOptions = "-u \$(id -u):\$(id -g)"?
It's making impossible to enable GATK Spark cf nf-core/sarek#76

@maxulysse maxulysse reopened this Dec 17, 2019
@apeltzer
Copy link
Member Author

I never had issues without it - so maybe it’s not required. We had people who had to use it though, which is something we should document / state in troubleshooting on the webpage maybe ?

@maxulysse
Copy link
Member

Anyhow, I'll be removing that for Sarek, I'll keep everyone updated if any issue arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template nf-core pipeline/component template
Projects
None yet
Development

No branches or pull requests

6 participants