Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options for DockerRun #352

Merged
merged 4 commits into from
Jun 28, 2019
Merged

Options for DockerRun #352

merged 4 commits into from
Jun 28, 2019

Conversation

apeltzer
Copy link
Member

This just modifies some of the changes in #351 to get this merged into devASAP:

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md

@apeltzer apeltzer requested review from maxulysse and drpatelh June 28, 2019 07:03
sven1103
sven1103 approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@sven1103 sven1103 merged commit 688bb19 into dev Jun 28, 2019
@sven1103 sven1103 deleted the dockerrunOptions branch June 28, 2019 07:44
@ewels ewels mentioned this pull request Oct 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1103 sven1103 sven1103 approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse

@drpatelh drpatelh Awaiting requested review from drpatelh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeltzer @sven1103 @olgabot