Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iGenomes paths wrong for GRCm38 #418

Closed
drpatelh opened this issue Oct 10, 2019 · 2 comments
Closed

iGenomes paths wrong for GRCm38 #418

drpatelh opened this issue Oct 10, 2019 · 2 comments
Labels
bug Something isn't working high-priority

Comments

@drpatelh
Copy link
Member

These lines should point to GRCm38 and not GRCh37! Does this require a patch? If it isnt spotted by the pipeline developer it could lead to issues. Hopefully, the pipeline fails because the annotation files arent consistent but possibly not worth the risk...

bowtie2 = "${params.igenomes_base}/Mus_musculus/Ensembl/GRCh37/Sequence/Bowtie2Index/"
bwa = "${params.igenomes_base}/Mus_musculus/Ensembl/GRCh37/Sequence/BWAIndex/"

@drpatelh drpatelh added bug Something isn't working high-priority labels Oct 10, 2019
@apeltzer
Copy link
Member

apeltzer commented Oct 10, 2019

Just double-checked and it should at least fail:

ls -l /nfsmounts/igenomes/Mus_musculus/Ensembl
GRCm38
NCBIM37

Still bad as it will not work, but we should definitely patch this asap!

apeltzer added a commit to apeltzer/tools that referenced this issue Oct 10, 2019
@apeltzer
Copy link
Member

see #419 for a PR

drpatelh added a commit that referenced this issue Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

No branches or pull requests

2 participants