Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate --max_memory and --max_time parameters and exit if not a valid Nextflow resource unit #793

Closed
drpatelh opened this issue Nov 23, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@drpatelh
Copy link
Member

Using --max_memory 80 should be validated properly as a Nextflow memory unit and if not to generate an error. The correct way of specifying this would be for example --max_memory '42 GB' otherwise the pipeline just allocates a memory value of 0 and still proceeds as normal. This was initially reported here.

@ewels
Copy link
Member

ewels commented Dec 16, 2020

Actually in your example I think that it is a valid memory unit, it will allocate 80 bytes of memory.. 👀

@ewels
Copy link
Member

ewels commented Dec 16, 2020

This should be handled by the JSON schema parameter validation if we set the schema validation to only accept values with a GB (or TB / PB) suffix. This will mean that people are then not able to specify a huge value in bytes, but I think that's ok.

@ewels ewels linked a pull request Dec 16, 2020 that will close this issue
2 tasks
@ewels ewels added this to the 1.13 milestone Feb 17, 2021
ewels added a commit to ewels/nf-core-tools that referenced this issue Feb 17, 2021
@ewels ewels closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants