Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct output of nf-core modules create-test-yml to tmp dir #1098

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

KevinMenden
Copy link
Contributor

This directs the output of nf-core modules create-test-yml to a tmp directory.

Addresses #908 (partly)
The .nextflow* stuff is still not cleaned up but I'd say we can live with that.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #1098 (fed86ce) into dev (afbed88) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1098   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files          36       36           
  Lines        4545     4545           
=======================================
  Hits         3198     3198           
  Misses       1347     1347           
Impacted Files Coverage Δ
nf_core/modules/test_yml_builder.py 45.94% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ccd25c...fed86ce. Read the comment docs.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-test-yml: move 'work' and '.nextflow*' files to tmp directory
2 participants