Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline verification function to nf-core lint #1208

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

ErikDanielsson
Copy link
Contributor

@ErikDanielsson ErikDanielsson commented Jul 16, 2021

The nf-core lint command was complaining about missing the modules.json file, as reported in #1198. This PR adds the ModulesCommand.has_valid_pipeline function that checks whether the pipeline is valid and adds the modules.json file if it is missing.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1208 (f60d25b) into dev (2d32038) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1208      +/-   ##
==========================================
- Coverage   69.47%   69.45%   -0.02%     
==========================================
  Files          49       49              
  Lines        5415     5419       +4     
==========================================
+ Hits         3762     3764       +2     
- Misses       1653     1655       +2     
Impacted Files Coverage Δ
nf_core/lint/__init__.py 70.27% <50.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d32038...f60d25b. Read the comment docs.

@drpatelh
Copy link
Member

Thanks @ErikDanielsson !

and adds the modules.json file if it is missing.

What if don't want need a modules.json file e.g. in the nf-core/fetchngs pipeline we only have local modules

@ErikDanielsson
Copy link
Contributor Author

ErikDanielsson commented Jul 16, 2021

If we only a have local modules the command will create a modules.json file with no entries @drpatelh. In my opinion this is better than not having the file at all, since it indicates that we shouldn't have any remote modules present in the pipeline.

@drpatelh
Copy link
Member

Sounds reasonable 👍🏽

@drpatelh drpatelh merged commit 5342803 into nf-core:dev Jul 16, 2021
@ErikDanielsson ErikDanielsson deleted the modules-json-creation-lint branch July 26, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants