Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nextflow.config #1211

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Update nextflow.config #1211

merged 2 commits into from
Nov 16, 2021

Conversation

maxulysse
Copy link
Member

Load genomes after profiles in case they are changed (ie tests)
(sarek stuff)

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Load genomes after profiles in case they are changed (ie tests)
(sarek stuff)
@github-actions

This comment has been minimized.

@maxulysse maxulysse changed the base branch from master to dev July 16, 2021 15:56
@drpatelh
Copy link
Member

Wow! Didn't realise this would actually matter? Does this mean we need to load all the other configs there after loading the profle too? How did you test for this fix?

@maxulysse
Copy link
Member Author

Sorry did not see your message earlier.

Wow! Didn't realise this would actually matter? Does this mean we need to load all the other configs there after loading the profle too? How did you test for this fix?

I tested the fix on sarek (obviously)

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@ewels ewels merged commit 14abb1b into dev Nov 16, 2021
@ewels ewels deleted the maxulysse-patch-2 branch November 16, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants