Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex in readme test of nf-core lint #1261

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

ErikDanielsson
Copy link
Contributor

@ErikDanielsson ErikDanielsson commented Aug 9, 2021

Updated the Nextflow installation link in the readme test of nf-core lint to agree to the link in the pipeline template. Should close #1260.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1261 (30efe6e) into dev (4c8886e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 30efe6e differs from pull request most recent head 5989fe9. Consider uploading reports for the commit 5989fe9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1261      +/-   ##
==========================================
+ Coverage   67.39%   67.45%   +0.05%     
==========================================
  Files          50       50              
  Lines        5607     5607              
==========================================
+ Hits         3779     3782       +3     
+ Misses       1828     1825       -3     
Impacted Files Coverage Δ
nf_core/lint/readme.py 79.31% <100.00%> (+10.34%) ⬆️
nf_core/lint_utils.py 87.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8886e...5989fe9. Read the comment docs.

@ewels ewels enabled auto-merge August 9, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants