Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yamllint config to template #1408

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Conversation

JoseEspinosa
Copy link
Member

Adds a .yamllint.yml config to avoid line too long and missing document start "---" errors.

Closes #1407

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@JoseEspinosa JoseEspinosa marked this pull request as ready for review February 10, 2022 21:31
@JoseEspinosa JoseEspinosa requested a review from mashehu February 10, 2022 21:31
@mashehu
Copy link
Contributor

mashehu commented Feb 11, 2022

For completeness sake, should we also have yamllint for the tools repo itself?

@maxulysse
Copy link
Member

For completeness sake, should we also have yamllint for the tools repo itself?

I'd say even for all repos with yml files

@mashehu
Copy link
Contributor

mashehu commented Feb 11, 2022

Which ones are left? Modules has it. nfco.re not yet.

@maxulysse
Copy link
Member

Which ones are left? Modules has it. nfco.re not yet.

technically every repo with some GHA has some yml, so configs could need that as well

@maxulysse
Copy link
Member

While we're at it, we should probably add it to our extension pack on vs code: https://github.com/nf-core/vscode-extensionpack

@JoseEspinosa
Copy link
Member Author

Will add it to tools in this same PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants