Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: don't install modules that this module is a substring of. #1441

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 14, 2022

All fixed with a single forward slash!

Closes #1380

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels linked an issue Mar 14, 2022 that may be closed by this pull request
Copy link
Contributor

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1441 (5616656) into dev (7e5ed84) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1441      +/-   ##
==========================================
- Coverage   65.69%   65.55%   -0.14%     
==========================================
  Files          50       50              
  Lines        5844     5839       -5     
==========================================
- Hits         3839     3828      -11     
- Misses       2005     2011       +6     
Impacted Files Coverage Δ
nf_core/modules/modules_repo.py 74.44% <100.00%> (-1.12%) ⬇️
nf_core/modules/create.py 79.16% <0.00%> (-1.15%) ⬇️
nf_core/modules/test_yml_builder.py 48.35% <0.00%> (-0.94%) ⬇️
nf_core/utils.py 82.95% <0.00%> (-0.55%) ⬇️
nf_core/modules/remove.py 79.59% <0.00%> (-0.41%) ⬇️
nf_core/sync.py 51.60% <0.00%> (-0.20%) ⬇️
nf_core/modules/module_utils.py 38.29% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5ed84...5616656. Read the comment docs.

@maxulysse maxulysse merged commit bde4731 into nf-core:dev Mar 14, 2022
@ewels ewels deleted the modules-prefix-issue-1380 branch March 14, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All modules with the same prefix being found with nf-core modules update
3 participants