Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume manifest will be set in the nextflow config. #1449

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 15, 2022

Fixes #1418

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels linked an issue Mar 15, 2022 that may be closed by this pull request
2 tasks
Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1449 (e315342) into dev (eb35d3a) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev    #1449   +/-   ##
=======================================
  Coverage   64.81%   64.81%           
=======================================
  Files          51       51           
  Lines        5977     5977           
=======================================
  Hits         3874     3874           
  Misses       2103     2103           
Impacted Files Coverage Δ
nf_core/modules/module_utils.py 38.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb35d3a...e315342. Read the comment docs.

@sateeshperi sateeshperi merged commit 829f822 into nf-core:dev Mar 15, 2022
@ewels ewels deleted the missing-manifests branch March 15, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] KeyError when installing modules
2 participants