Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: yaml => yml #1471

Merged
merged 2 commits into from
Mar 18, 2022
Merged

style: yaml => yml #1471

merged 2 commits into from
Mar 18, 2022

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Mar 18, 2022

It's the only yaml file in a sea of yml

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team yml 🎉

But seriously, does it have any side-effects?

@apeltzer apeltzer changed the base branch from master to dev March 18, 2022 10:56
@ewels
Copy link
Member

ewels commented Mar 18, 2022

MultiQC shouldn't care, it loads both. It may affect template sync stuff maybe? But yeah it's probably fine.

@maxulysse
Copy link
Member

@emiller88 If you fix the tests as well, would be perfect

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1471 (136c34b) into dev (3abb7ef) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##              dev    #1471   +/-   ##
=======================================
  Coverage   64.87%   64.87%           
=======================================
  Files          52       52           
  Lines        6055     6055           
=======================================
  Hits         3928     3928           
  Misses       2127     2127           
Impacted Files Coverage Δ
nf_core/lint/files_exist.py 81.81% <ø> (ø)
nf_core/lint/multiqc_config.py 80.43% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abb7ef...136c34b. Read the comment docs.

@edmundmiller
Copy link
Contributor Author

@maxulysse Done!

@maxulysse maxulysse merged commit 8eb2228 into dev Mar 18, 2022
@maxulysse maxulysse deleted the multiqc-yml branch March 18, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants