-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First stab at writing a central utils function for GitHub API calls. #1499
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Might be worth looking into doing API requests using a shared See also: https://requests-cache.readthedocs.io/en/stable/user_guide/general.html#sessions Could then just define the auth once for the whole run, and might be faster when we're doing a lot of calls to the GitHub API. |
Uses authentication from local gh CLI or a supplied bearer token if found. Done to address nf-core#1496 Bit scared it'll break something, so ideally needs extensive testing.
Also removed function prefix from calls that were in the same file
This comment was marked as resolved.
This comment was marked as resolved.
Leave this for another day I think. Especially as we may rewrite how the modules code works, so drop the number of GitHub API calls that we're doing anyway. |
to install locally |
Works locally. (lint fails, but we're not hitting limit of API calls anymore) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Thank you for the help @mirpedrol! |
Uses authentication from local gh CLI or a supplied bearer token if found.
Done to address #1496
Bit scared it'll break something, so ideally needs extensive testing.
PR checklist
CHANGELOG.md
is updateddocs
is updated