Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert email template prettier #1510

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Revert email template prettier #1510

merged 2 commits into from
Apr 6, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Apr 6, 2022 •
edited
Loading

Closes #1509

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions

This comment was marked as resolved.

Sign in to view
@ewels ewels mentioned this pull request Apr 6, 2022
Closed
@ewels ewels changed the base branch from master to dev April 6, 2022 14:01
@codecov

This comment was marked as off-topic.

Sign in to view
edmundmiller
edmundmiller approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any plans to fix this in the future? Happy with the quick fix, as I think keeping the template linted is pretty low priority, just asking, so we can document the decision, and make an issue of it or not.

@ewels
Copy link
Member Author

ewels commented Apr 6, 2022

I mostly want to patch this before the next release (next week).

If you fancy doing a better fix then that would be welcome. Can probably use different groovy syntax to do avoid ignoring (or just ignore subsections). It just needs extensive testing and I knew that the old version worked.

@ewels ewels merged commit 821b34d into nf-core:dev Apr 6, 2022
@ewels ewels deleted the revert-email-template-prettier branch April 6, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@JoseEspinosa JoseEspinosa Awaiting requested review from JoseEspinosa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to parse template script for workflow.onComplete event handler
2 participants
@ewels @edmundmiller