Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert to single dag.file file format for linting #1517

Merged
merged 2 commits into from
Apr 14, 2022
Merged

revert to single dag.file file format for linting #1517

merged 2 commits into from
Apr 14, 2022

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Apr 14, 2022 •
edited
Loading

#1512 introduced code to allow all nf-core supported DAG graph formats in the default linting. This was not desired and thus removed in this PR.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@fabianegli fabianegli requested a review from ewels April 14, 2022 18:08
@codecov

This comment was marked as resolved.

Sign in to view
ewels
ewels approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ewels ewels merged commit 3586baf into nf-core:dev Apr 14, 2022
@fabianegli
Copy link
Contributor Author

With pleasure 😄

@fabianegli fabianegli deleted the fabianegli-remove-graphviz-dependency branch April 18, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianegli @ewels