Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print include statement when modules install #1520

Merged
merged 6 commits into from
Apr 27, 2022
Merged

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Apr 21, 2022

Closes #1420

When using nf-core modules install print the include statements to terminal for easy copy to destination files.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1520 (f0f5258) into dev (faf4716) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1520      +/-   ##
==========================================
- Coverage   64.91%   64.86%   -0.06%     
==========================================
  Files          52       52              
  Lines        6063     6065       +2     
==========================================
- Hits         3936     3934       -2     
- Misses       2127     2131       +4     
Impacted Files Coverage Δ
nf_core/modules/install.py 59.09% <100.00%> (+0.95%) ⬆️
nf_core/modules/create.py 79.27% <0.00%> (-1.04%) ⬇️
nf_core/utils.py 83.00% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf4716...f0f5258. Read the comment docs.

@mirpedrol mirpedrol marked this pull request as ready for review April 21, 2022 09:35
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@drpatelh
Copy link
Member

Yes, sorry, I wanted to test this branch to see how the log.info for the include was printed to screen but that's a minor change if we need to make it.

@drpatelh drpatelh merged commit a383d6c into nf-core:dev Apr 27, 2022
@mirpedrol mirpedrol deleted the include branch May 17, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants