Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve update.py #1536

Merged
merged 107 commits into from
Jul 21, 2022
Merged

Commits on Apr 28, 2022

  1. remove unused import

    fabianegli committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    6e5b7a3 View commit details
    Browse the repository at this point in the history
  2. use early return pattern

    fabianegli committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    d5c1112 View commit details
    Browse the repository at this point in the history
  3. bug fix: variable name

    fabianegli committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    789b76d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e753d9f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5764ead View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. use nested unpacking

    fabianegli committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    e3d24b3 View commit details
    Browse the repository at this point in the history
  2. wrapping f-strings

    fabianegli committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    2491a03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af726e6 View commit details
    Browse the repository at this point in the history
  4. use a list comprehension

    fabianegli committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7f892f2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0c2089b View commit details
    Browse the repository at this point in the history
  6. adopt isort

    fabianegli committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    81a1147 View commit details
    Browse the repository at this point in the history
  7. remove unused import

    fabianegli committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    64d27e7 View commit details
    Browse the repository at this point in the history
  8. use import from

    fabianegli committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    0b58244 View commit details
    Browse the repository at this point in the history
  9. use list comprehension

    fabianegli committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    4293b0c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b170827 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e9e92f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    89a115b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2e44600 View commit details
    Browse the repository at this point in the history
  14. remove unused import

    fabianegli committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    6e0ab52 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Configuration menu
    Copy the full SHA
    de5dcb7 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Fix nf-core#1419

    drpatelh authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    19f3728 View commit details
    Browse the repository at this point in the history
  2. Black

    drpatelh authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    36e5469 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e100be0 View commit details
    Browse the repository at this point in the history
  4. Deep copy of schema not needed

    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    143c041 View commit details
    Browse the repository at this point in the history
  5. Format strings

    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    4cc3b04 View commit details
    Browse the repository at this point in the history
  6. print include statement when installing a module

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    5edb359 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b0794f7 View commit details
    Browse the repository at this point in the history
  8. remove remove stringtie special case

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    dccef6c View commit details
    Browse the repository at this point in the history
  9. Update actions_ci.py

    In cases where e.g. multiple aligners are specified in the GitHub Actions matrix, trying to pull a 'NXF_VER' key out of the include dictionary can cause line 140 to fail when it shouldn't. The get() method will not error if the key is not present, fixing this problem.
    njspix authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    2536266 View commit details
    Browse the repository at this point in the history
  10. resolve rebase mergeconflicts

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    1876107 View commit details
    Browse the repository at this point in the history
  11. run tests with pytest

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    2e713dd View commit details
    Browse the repository at this point in the history
  12. remove test workflow check

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b55aeca View commit details
    Browse the repository at this point in the history
  13. add code tests

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    41e2232 View commit details
    Browse the repository at this point in the history
  14. fix linting

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    20dd418 View commit details
    Browse the repository at this point in the history
  15. apply comments from PR review

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    3622615 View commit details
    Browse the repository at this point in the history
  16. fix linting

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    d88a6cd View commit details
    Browse the repository at this point in the history
  17. apply comments from PR

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    3f2a1de View commit details
    Browse the repository at this point in the history
  18. fix test

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    f3dc187 View commit details
    Browse the repository at this point in the history
  19. always set profile

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    e7fdd53 View commit details
    Browse the repository at this point in the history
  20. do not abbreviate env var

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    005143a View commit details
    Browse the repository at this point in the history
  21. add new test

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    9f48c90 View commit details
    Browse the repository at this point in the history
  22. update CHANGELOG

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    d59497b View commit details
    Browse the repository at this point in the history
  23. specify test files as test_*.py in pytest.ini

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    5a61003 View commit details
    Browse the repository at this point in the history
  24. apply comments from PR review

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    98f0239 View commit details
    Browse the repository at this point in the history
  25. check if profile is available

    Júlia Mir Pedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    86dabbf View commit details
    Browse the repository at this point in the history
  26. modify linting

    mirpedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    37750dc View commit details
    Browse the repository at this point in the history
  27. Add nf-core/modules folder warning

    Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
    2 people authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    a0ac5a1 View commit details
    Browse the repository at this point in the history
  28. Add valid profile check

    Co-authored-by: Fabian Egli <fabianegli@users.noreply.github.com>
    mirpedrol and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    e45dbfd View commit details
    Browse the repository at this point in the history
  29. fix linting

    mirpedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    cfa2e1c View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    5dce262 View commit details
    Browse the repository at this point in the history
  31. Apply suggestions from code review

    Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
    2 people authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    930601d View commit details
    Browse the repository at this point in the history
  32. remove unnecessary libraryes

    mirpedrol authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    0d4f813 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    b4343ae View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    c9acfb5 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    9fd0352 View commit details
    Browse the repository at this point in the history
  36. Add biocontainers reference

    Co-authored-by: Moritz E. Beber <midnighter@posteo.net>
    2 people authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    1afd36b View commit details
    Browse the repository at this point in the history
  37. First stab at writing a central utils function for GitHub API calls.

    Uses authentication from local gh CLI or a supplied bearer token if found.
    
    Done to address nf-core#1496
    
    Bit scared it'll break something, so ideally needs extensive testing.
    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    90ec221 View commit details
    Browse the repository at this point in the history
  38. Remove superfluous dict() call

    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    e0f984f View commit details
    Browse the repository at this point in the history
  39. Fix sync pytests

    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    464510e View commit details
    Browse the repository at this point in the history
  40. Better debug logging.

    Also removed function prefix from calls that were in the same file
    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    fb2c4cf View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    d37dbff View commit details
    Browse the repository at this point in the history
  42. Use new class more in the sync code

    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    605dc8a View commit details
    Browse the repository at this point in the history
  43. Nearly fix the tests

    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    002deff View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    4cbbee8 View commit details
    Browse the repository at this point in the history
  45. Use XDG_CONFIG_HOME or ~/.config/nf-core/ for the requests cache dir.

    Suggested by @emiller88 👍🏻
    ewels authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    de429f7 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    c0f179d View commit details
    Browse the repository at this point in the history
  47. Apply suggestions from code review

    Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
    2 people authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    1490a0b View commit details
    Browse the repository at this point in the history
  48. Update nf_core/sync.py

    Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
    2 people authored and fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    7227dad View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    ffa278b View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    6ef8255 View commit details
    Browse the repository at this point in the history
  51. if-else instead of if-if

    fabianegli committed May 12, 2022
    Configuration menu
    Copy the full SHA
    3dfbacc View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    b60a424 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Configuration menu
    Copy the full SHA
    3e203a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97fb34e View commit details
    Browse the repository at this point in the history
  3. Merge branch 'fabianegli-update-refactor' of github.com:fabianegli/to…

    …ols into fabianegli-update-refactor
    fabianegli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    690268a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    869305e View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Configuration menu
    Copy the full SHA
    c793838 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Configuration menu
    Copy the full SHA
    e0cb22c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f92853 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'fabianegli-update-refactor' of github.com:fabianegli/to…

    …ols into fabianegli-update-refactor
    fabianegli committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    944955c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    caad096 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Configuration menu
    Copy the full SHA
    038597b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c06c03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bdee1d5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ea61cb3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fe42c54 View commit details
    Browse the repository at this point in the history
  6. Always move files to temp dir first, to make sure the installation wo…

    …rks before removing files
    ErikDanielsson committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    d51e097 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2686e9a View commit details
    Browse the repository at this point in the history
  8. Move the update method

    ErikDanielsson committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    b8cfed3 View commit details
    Browse the repository at this point in the history
  9. fix variable name

    fabianegli committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    100d311 View commit details
    Browse the repository at this point in the history
  10. More misc. refactoring

    ErikDanielsson committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    4522d69 View commit details
    Browse the repository at this point in the history
  11. Merge branch 'fabianegli-update-refactor' of github.com:fabianegli/to…

    …ols into fabianegli-update-refactor
    ErikDanielsson committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    685d301 View commit details
    Browse the repository at this point in the history
  12. Fix tests

    ErikDanielsson committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    7df4f57 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e4f6e9b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1949497 View commit details
    Browse the repository at this point in the history
  15. Update CHANGELOG.md

    ErikDanielsson committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    9d2c29c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Update CHANGELOG.md

    Co-authored-by: Fabian Egli <fabianegli@users.noreply.github.com>
    ErikDanielsson and fabianegli authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    9145b6c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cdc79c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be5cf77 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f39d97d View commit details
    Browse the repository at this point in the history
  5. break too long line

    fabianegli committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    8fddf53 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d949be1 View commit details
    Browse the repository at this point in the history
  7. Fix changelog

    ErikDanielsson committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    88ff09f View commit details
    Browse the repository at this point in the history
  8. Merge branch 'fabianegli-update-refactor' of github.com:fabianegli/to…

    …ols into fabianegli-update-refactor
    ErikDanielsson committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    c3a0ed9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6c79bd0 View commit details
    Browse the repository at this point in the history
  10. Update docs

    ErikDanielsson committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    ee59392 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    22f9ca7 View commit details
    Browse the repository at this point in the history