Module linting: refactor parsing of input channel names. #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more split, regexes FTW! Fixes nf-core#1542
This comment was marked as outdated.
This comment was marked as outdated.
mirpedrol
approved these changes
May 12, 2022
Midnighter
approved these changes
May 12, 2022
| """ | ||
| inputs = [] | ||
| # Remove comments and trailing whitespace | ||
| line, *_ = line_raw.partition("//") |
There was a problem hiding this comment.
How about?
Suggested change
| line, *_ = line_raw.partition("//") | |
| line = line_raw.split("//")[0] |
|
Sheesh, things move fast 🙂 |
|
hah, sorry! Yeah that's nicer 👍🏻 |
ewels
added a commit
to ewels/nf-core-tools
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more split, regexes FTW!
Fixes #1542
PR checklist
CHANGELOG.mdis updateddocsis updated