Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module lint: Allow no input or output in YAML #1576

Merged
merged 4 commits into from
May 13, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented May 13, 2022

In #1374 @drpatelh updated linting to allow input and output to be omitted from main.nf. However, the linting was still checking for these in meta.yml.

Also added in some slight lint message tweaks to help clarify things.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from drpatelh May 13, 2022 11:17
@ewels ewels added this to the 2.4 milestone May 13, 2022
@codecov

This comment was marked as resolved.

nf_core/modules/lint/meta_yml.py Outdated Show resolved Hide resolved
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@ewels ewels marked this pull request as draft May 13, 2022 12:21
@ewels
Copy link
Member Author

ewels commented May 13, 2022

Put back check for output statement.

@ewels ewels marked this pull request as ready for review May 13, 2022 14:16
@ewels ewels merged commit 899a949 into nf-core:dev May 13, 2022
@ewels ewels deleted the module-lint-allow-no-input-output branch May 13, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants