Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise if Singularity container retrieval fails #1622

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Jun 1, 2022

There has been a test that xfailed - It seems that failing to retrieve a container image should have always raised an exception, but it didn't. Now it does and the test that was maked xfail is now split into two tests, one that tests the failure mode if Singularity isn't installed and one for the case Singularity is installed but the container image retrieval fails.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1622 (8b751ef) into dev (dd7b59b) will decrease coverage by 0.06%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##              dev    #1622      +/-   ##
==========================================
- Coverage   64.44%   64.37%   -0.07%     
==========================================
  Files          54       54              
  Lines        6288     6294       +6     
==========================================
  Hits         4052     4052              
- Misses       2236     2242       +6     
Impacted Files Coverage Δ
nf_core/download.py 53.69% <10.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7b59b...8b751ef. Read the comment docs.

tests/test_download.py Outdated Show resolved Hide resolved
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth adding this change to CHANGELOG, otherwise it looks good to me

nf_core/download.py Show resolved Hide resolved
tests/test_download.py Outdated Show resolved Hide resolved
@fabianegli fabianegli merged commit 2678569 into nf-core:dev Jun 15, 2022
@fabianegli fabianegli deleted the raise-for-singularity-container-retrieval-fail branch June 15, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants