-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change base cache dir #1636
Change base cache dir #1636
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1636 +/- ##
=======================================
Coverage 64.39% 64.39%
=======================================
Files 54 54
Lines 6299 6299
=======================================
Hits 4056 4056
Misses 2243 2243
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. Did you check if there is the potential to adopt basedir-spec in other places in this code base?
Not sure what we do, but do we need to alarm users about a stale cache after the change?
I don't think we have any other persistent files than the caches between sessions, so this should be the only place needing to change currently. Good idea, I will look into how we did it the last time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Not too fussed about the stale files. We're going to use the same path in a moment for modules stuff so it will be subfiles in an active subdir. They shouldn't cause too many problems, I think telling people about them will cause more problems 😆 |
The base cache directory was changed in a previous PR be to
$XDG_CONFIG_DIR
or.config
. In my opinion it makes more sense to use$XDG_CACHE_DIR
or.cache
.PR checklist
CHANGELOG.md
is updateddocs
is updated