-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generic git remotes #1641
Conversation
… more flexible git support
Codecov Report
@@ Coverage Diff @@
## dev #1641 +/- ##
==========================================
+ Coverage 64.39% 64.84% +0.45%
==========================================
Files 54 54
Lines 6299 6270 -29
==========================================
+ Hits 4056 4066 +10
+ Misses 2243 2204 -39
Continue to review full report at Codecov.
|
Clone progress bar: use percentage for progress, more colour on the left and a rich URL to make it a clickable link for the remote. |
Co-authored-by: Phil Ewels <phil@seqera.io>
…o get-generic-git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦜
Until now, we have used the GitHub API to work with remote modules repositories. As is outlined in #1626, this limits the possible git remotes to GitHub. In this PR I have rewritten how we handle git remotes in the modules commands to work with any remote that works with command line git. This works by cloning the remote repositories into the
.nfcore
directory. When runningmodules
command, we rungit pull
on all repositories that are affected by the command.Outline of changes
--github-repository
option is changed to--git-remote
, and the argument should be a valid git URL.--no-pull
flag tonf-core modules
. This allows the user to run a modules command without pulling the remote repository.modules.json
file is changed to keep track of the git URL. Hence, I have update the pipeline template. The new structure is as followsPR checklist
CHANGELOG.md
is updateddocs
is updated