Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --base-path option to modules commands (and refactor modules.json code) #1655

Merged
merged 22 commits into from
Jun 28, 2022

Conversation

ErikDanielsson
Copy link
Contributor

Added --base-path option to the modules commands to allow custom module directory in a remote repo. This required me to refactor the code for how the modules.json file is handled. It is moved to its own file now: modules_json.py and accessed through a ModuleJson object.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1655 (f8bec09) into dev (9bd0355) will increase coverage by 0.00%.
The diff coverage is 43.97%.

@@           Coverage Diff           @@
##              dev    #1655   +/-   ##
=======================================
  Coverage   64.68%   64.68%           
=======================================
  Files          54       55    +1     
  Lines        6281     6338   +57     
=======================================
+ Hits         4063     4100   +37     
- Misses       2218     2238   +20     
Impacted Files Coverage Δ
nf_core/modules/module_utils.py 53.53% <ø> (+19.12%) ⬆️
nf_core/modules/update.py 7.63% <10.00%> (-0.19%) ⬇️
nf_core/modules/modules_json.py 30.74% <30.74%> (ø)
nf_core/__main__.py 52.13% <75.00%> (+0.09%) ⬆️
nf_core/modules/lint/module_version.py 85.18% <76.92%> (-0.53%) ⬇️
nf_core/modules/modules_command.py 82.92% <80.00%> (+30.12%) ⬆️
nf_core/modules/remove.py 80.55% <87.50%> (+4.55%) ⬆️
nf_core/modules/modules_repo.py 76.97% <90.00%> (+1.64%) ⬆️
nf_core/modules/install.py 69.23% <93.75%> (+3.01%) ⬆️
nf_core/lint/modules_json.py 80.76% <100.00%> (+2.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd0355...f8bec09. Read the comment docs.

@ewels ewels requested a review from mirpedrol June 28, 2022 08:17
@ErikDanielsson ErikDanielsson linked an issue Jun 28, 2022 that may be closed by this pull request
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I also tested the functionality and it works fine :)

@ErikDanielsson
Copy link
Contributor Author

Thanks for the review! I'll merge it then.

@ErikDanielsson ErikDanielsson merged commit ee54b9f into nf-core:dev Jun 28, 2022
@ErikDanielsson ErikDanielsson deleted the custom-file-path branch July 26, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom path for modules directory
2 participants