-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --base-path
option to modules commands (and refactor modules.json
code)
#1655
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1655 +/- ##
=======================================
Coverage 64.68% 64.68%
=======================================
Files 54 55 +1
Lines 6281 6338 +57
=======================================
+ Hits 4063 4100 +37
- Misses 2218 2238 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I also tested the functionality and it works fine :)
Thanks for the review! I'll merge it then. |
Added
--base-path
option to themodules
commands to allow custom module directory in a remote repo. This required me to refactor the code for how themodules.json
file is handled. It is moved to its own file now:modules_json.py
and accessed through aModuleJson
object.PR checklist
CHANGELOG.md
is updateddocs
is updated