-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle errors when updating module version #1671
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1671 +/- ##
==========================================
- Coverage 69.07% 68.99% -0.09%
==========================================
Files 58 58
Lines 6950 6960 +10
==========================================
+ Hits 4801 4802 +1
- Misses 2149 2158 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just have look at my comment for a minor suggestion (:
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
I am going to merge this, it finally handles the annoying error with sqlite :) It's something related to a timeout, it's not failing locally. |
Code still looks good to me! But you should update the changelog :) |
thanks! |
Handle errors when trying to update a module version.
Needed for #1745
PR checklist
CHANGELOG.md
is updateddocs
is updated