Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle errors when updating module version #1671

Merged
merged 13 commits into from
Aug 1, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Jul 13, 2022

Handle errors when trying to update a module version.
Needed for #1745

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1671 (dee98e6) into dev (b7f44d3) will decrease coverage by 0.08%.
The diff coverage is 5.26%.

@@            Coverage Diff             @@
##              dev    #1671      +/-   ##
==========================================
- Coverage   69.07%   68.99%   -0.09%     
==========================================
  Files          58       58              
  Lines        6950     6960      +10     
==========================================
+ Hits         4801     4802       +1     
- Misses       2149     2158       +9     
Impacted Files Coverage Δ
nf_core/modules/lint/main_nf.py 64.17% <5.26%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f44d3...dee98e6. Read the comment docs.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just have look at my comment for a minor suggestion (:

nf_core/modules/lint/main_nf.py Outdated Show resolved Hide resolved
@mirpedrol
Copy link
Member Author

I am going to merge this, it finally handles the annoying error with sqlite :) It's something related to a timeout, it's not failing locally.
Some things have changed since the review, if you want to have a final look @ErikDanielsson

@ErikDanielsson
Copy link
Contributor

Code still looks good to me! But you should update the changelog :)

@mirpedrol
Copy link
Member Author

thanks!

@mirpedrol mirpedrol merged commit fb57fb9 into nf-core:dev Aug 1, 2022
@mirpedrol mirpedrol deleted the update-module branch August 1, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants