Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitpod and mamba profiles to the pipeline template #1673

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Add gitpod and mamba profiles to the pipeline template #1673

merged 2 commits into from
Jul 14, 2022

Conversation

mahesh-panchal
Copy link
Member

Adds profiles for gitpod and mamba to the pipeline template.
Gitpod requires a few additional settings in order to make full use of the resources for workflow testing.
Mamba is increasingly used over conda, and so it makes sense to have a profile for it.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Contributor

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@maxulysse
Copy link
Member

I like this idea

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1673 (cacb9b2) into dev (77f43e8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1673      +/-   ##
==========================================
- Coverage   68.07%   68.07%   -0.01%     
==========================================
  Files          56       56              
  Lines        6588     6587       -1     
==========================================
- Hits         4485     4484       -1     
  Misses       2103     2103              
Impacted Files Coverage Δ
nf_core/modules/remove.py 80.00% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f43e8...cacb9b2. Read the comment docs.

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, both would be useful. Is there docs confirming the size of a gitpod node? 60.GB seems quite large for a ('free'-service!)

@mahesh-panchal
Copy link
Member Author

There's no docs. It can change at any time to be honest. I use htop to check memory and cpus available

@mahesh-panchal mahesh-panchal merged commit 2763932 into nf-core:dev Jul 14, 2022
@mahesh-panchal mahesh-panchal deleted the dev branch July 14, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants