Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint for input mimetype #1676

Merged
merged 6 commits into from
Jul 19, 2022

Conversation

ErikDanielsson
Copy link
Contributor

Check that the input parameter has a mimetype. Should close #1647.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ErikDanielsson ErikDanielsson linked an issue Jul 14, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1676 (adc4df6) into dev (2763932) will decrease coverage by 0.08%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##              dev    #1676      +/-   ##
==========================================
- Coverage   68.07%   67.99%   -0.09%     
==========================================
  Files          56       56              
  Lines        6588     6609      +21     
==========================================
+ Hits         4485     4494       +9     
- Misses       2103     2115      +12     
Impacted Files Coverage Δ
nf_core/lint/schema_lint.py 76.66% <62.50%> (-5.16%) ⬇️
nf_core/schema.py 77.39% <66.66%> (-0.27%) ⬇️
nf_core/modules/create.py 79.27% <0.00%> (-1.04%) ⬇️
nf_core/utils.py 80.12% <0.00%> (-0.41%) ⬇️
nf_core/create.py 62.65% <0.00%> (-0.36%) ⬇️
nf_core/__main__.py 52.35% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2763932...adc4df6. Read the comment docs.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

nf_core/schema.py Outdated Show resolved Hide resolved
nf_core/lint/schema_lint.py Outdated Show resolved Hide resolved
@ErikDanielsson ErikDanielsson merged commit cc1ab61 into nf-core:dev Jul 19, 2022
@ErikDanielsson ErikDanielsson deleted the lint-for-mimetype branch July 26, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema: Lint for mimetype
2 participants