Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python version support #1680

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Jul 18, 2022

Currently, tools is built for Python versions 3.6, 3.7 and 3.8. 3.6 is deprecated and does not receive even security updates. This PR drops support for Python 3.6 and adds support for Python 3.9 and 3.10, which results in package target versions for Python 3.7, 3.8, 3.9 and 3.10.

The changes affect the package itself and the GitHub Action linting in the workflow template.

Closes #1621.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #1680 (3fa233f) into dev (ed355ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1680   +/-   ##
=======================================
  Coverage   68.00%   68.00%           
=======================================
  Files          56       56           
  Lines        6589     6589           
=======================================
  Hits         4481     4481           
  Misses       2108     2108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed355ed...3fa233f. Read the comment docs.

@apeltzer
Copy link
Member

Given that most projects nowadays start going towards 3.9+ already, I think this is a good idea. Shouldn't harm at least :-)

@apeltzer apeltzer enabled auto-merge July 18, 2022 20:19
@apeltzer apeltzer merged commit f59e600 into nf-core:dev Jul 18, 2022
@fabianegli fabianegli deleted the drop-python36-support branch July 21, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants