-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove assert and code cleanup #1685
remove assert and code cleanup #1685
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1685 +/- ##
==========================================
- Coverage 67.99% 67.74% -0.25%
==========================================
Files 56 56
Lines 6609 6654 +45
==========================================
+ Hits 4494 4508 +14
- Misses 2115 2146 +31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The changelog needs updating before we merge though.
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a typo.
This PR removes all assert statements from production code.
It also contains minuscule code cleanup and speedups.
Closes #1533
PR checklist
CHANGELOG.md
is updateddocs
is updated