Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove assert and code cleanup #1685

Merged
merged 4 commits into from
Jul 21, 2022

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Jul 20, 2022

This PR removes all assert statements from production code.

It also contains minuscule code cleanup and speedups.

Closes #1533

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #1685 (4787815) into dev (cc1ab61) will decrease coverage by 0.24%.
The diff coverage is 62.71%.

@@            Coverage Diff             @@
##              dev    #1685      +/-   ##
==========================================
- Coverage   67.99%   67.74%   -0.25%     
==========================================
  Files          56       56              
  Lines        6609     6654      +45     
==========================================
+ Hits         4494     4508      +14     
- Misses       2115     2146      +31     
Impacted Files Coverage Δ
nf_core/__main__.py 52.95% <12.50%> (+0.59%) ⬆️
nf_core/lint/multiqc_config.py 66.66% <50.00%> (-14.59%) ⬇️
nf_core/lint/readme.py 75.75% <50.00%> (-4.89%) ⬇️
nf_core/utils.py 80.32% <50.00%> (+0.20%) ⬆️
nf_core/launch.py 63.93% <62.50%> (-0.41%) ⬇️
nf_core/lint/actions_awsfulltest.py 83.33% <66.66%> (-5.56%) ⬇️
nf_core/schema.py 75.88% <69.76%> (-1.51%) ⬇️
nf_core/lint/actions_awstest.py 78.94% <75.00%> (-4.39%) ⬇️
nf_core/lint/actions_ci.py 85.48% <78.57%> (-3.61%) ⬇️
nf_core/lint/nextflow_config.py 77.45% <85.71%> (-0.11%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1ab61...4787815. Read the comment docs.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The changelog needs updating before we merge though.

nf_core/lint/nextflow_config.py Outdated Show resolved Hide resolved
fabianegli and others added 2 commits July 21, 2022 09:59
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a typo.

CHANGELOG.md Outdated Show resolved Hide resolved
@fabianegli fabianegli merged commit c5a4295 into nf-core:dev Jul 21, 2022
@fabianegli fabianegli deleted the remove-assert-from-production-code branch July 21, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants