-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_git=True when possible #1709
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1709 +/- ##
=======================================
Coverage 68.23% 68.23%
=======================================
Files 57 57
Lines 6744 6744
=======================================
Hits 4602 4602
Misses 2142 2142
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do the same in tests/test_lint.py
, tests/test_utils.py
and tests/test_modules.py
also right?
Thanks @ErikDanielsson, I forgot some tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
As mentioned in #1688 comment
The argument no_git=True can be added when a pipeline is created but there's no need to initialise a git repository.
PR checklist
CHANGELOG.md
is updateddocs
is updated