Add branch
field to module entries in modules.json
to record what branch a module comes from
#1738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I reported in #1728, the commands that rely on version information in the
modules.json
fail if a module was installed from a branch other than the default branch. I've fixed this by adding branch information to the module entries in themodules.json
. The updatedmodules.json
looks something like thisTo add this feature I needed to refactor the
check_up_to_date
method inmodules_json.py
since it was to big and unruly to be modified directly.The new feature is tested using a new
branch-tester
branch in thenf-core/modules-test
repository on gitlab.PR checklist
CHANGELOG.md
is updateddocs
is updated