Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add apply patch reverse when create modules.json #1752

Merged
merged 8 commits into from
Aug 19, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Aug 18, 2022

Closes #1723

When creating modules.json file, if a patch file exists for a module, apply the patch in reverse to find the commit_sha.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1752 (cd944ba) into dev (fb46b6d) will increase coverage by 0.12%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##              dev    #1752      +/-   ##
==========================================
+ Coverage   68.40%   68.52%   +0.12%     
==========================================
  Files          59       59              
  Lines        7130     7152      +22     
==========================================
+ Hits         4877     4901      +24     
+ Misses       2253     2251       -2     
Impacted Files Coverage Δ
nf_core/modules/modules_json.py 73.27% <91.30%> (+1.13%) ⬆️
nf_core/modules/modules_differ.py 86.43% <0.00%> (+0.50%) ⬆️
nf_core/modules/modules_repo.py 84.18% <0.00%> (+1.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol marked this pull request as ready for review August 19, 2022 07:27
tests/modules/modules_json.py Outdated Show resolved Hide resolved
tests/modules/modules_json.py Outdated Show resolved Hide resolved
mirpedrol and others added 3 commits August 19, 2022 13:20
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mirpedrol mirpedrol merged commit 3cad041 into nf-core:dev Aug 19, 2022
@mirpedrol mirpedrol deleted the patch branch August 19, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants