Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --base-path option #1754

Merged
merged 17 commits into from
Aug 22, 2022
Merged

Remove --base-path option #1754

merged 17 commits into from
Aug 22, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Aug 19, 2022

As discussed in #1732
Remove --base-path option.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1754 (1e6513d) into dev (3cad041) will decrease coverage by 0.06%.
The diff coverage is 81.57%.

@@            Coverage Diff             @@
##              dev    #1754      +/-   ##
==========================================
- Coverage   68.52%   68.46%   -0.07%     
==========================================
  Files          59       59              
  Lines        7152     7131      -21     
==========================================
- Hits         4901     4882      -19     
+ Misses       2251     2249       -2     
Impacted Files Coverage Δ
nf_core/modules/info.py 17.03% <50.00%> (ø)
nf_core/modules/modules_repo.py 82.85% <57.14%> (-1.33%) ⬇️
nf_core/modules/modules_json.py 73.37% <78.57%> (+0.09%) ⬆️
nf_core/__main__.py 52.67% <100.00%> (+0.01%) ⬆️
nf_core/modules/bump_versions.py 63.69% <100.00%> (ø)
nf_core/modules/install.py 69.56% <100.00%> (-2.81%) ⬇️
nf_core/modules/lint/__init__.py 82.47% <100.00%> (ø)
nf_core/modules/list.py 71.23% <100.00%> (ø)
nf_core/modules/modules_command.py 83.78% <100.00%> (ø)
nf_core/modules/patch.py 80.70% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol marked this pull request as ready for review August 19, 2022 10:57
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one tiny thing

nf_core/modules/modules_repo.py Outdated Show resolved Hide resolved
mirpedrol and others added 2 commits August 19, 2022 14:03
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mirpedrol
Copy link
Member Author

@nf-core-bot fix linting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants