Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ubuntu-latest for api docs generatoin and release #1762

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Aug 23, 2022

GitHub Actions seems to be deprecating Ubuntu 18.04 and thus some of the tests start failing. This PR makes it so ubuntu-latest is used in all workflows as the base image that until now use Ubuntu 18.04.

The issue surfaced because this PR test failed.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@fabianegli fabianegli force-pushed the use-ubuntu-latest-for-api-docs branch from 855daaf to ab7e3e3 Compare August 23, 2022 10:41
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1762 (ab7e3e3) into dev (8fc04a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1762   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files          59       59           
  Lines        7132     7132           
=======================================
  Hits         4931     4931           
  Misses       2201     2201           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, also caught by @mashehu but you fixed it faster! 🏃🏻

@ewels ewels merged commit 9c8614b into nf-core:dev Aug 23, 2022
@fabianegli fabianegli deleted the use-ubuntu-latest-for-api-docs branch August 23, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants