Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GitHub PyPI publish action release v1 #1785

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Aug 30, 2022

Closes #1783

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @fabianegli,

It looks like this pull-request is has been made against the nf-core/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@fabianegli fabianegli changed the base branch from master to dev August 30, 2022 13:53
@fabianegli fabianegli force-pushed the use-publish-action-release-v1 branch from ddf118a to 261c473 Compare August 30, 2022 13:56
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1785 (2d51c96) into dev (f105f49) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1785   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          59       59           
  Lines        7148     7148           
=======================================
  Hits         4950     4950           
  Misses       2198     2198           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fabianegli fabianegli force-pushed the use-publish-action-release-v1 branch from 620de8a to ac17b0b Compare August 30, 2022 18:27
@fabianegli fabianegli force-pushed the use-publish-action-release-v1 branch from ac17b0b to 2d51c96 Compare August 31, 2022 09:13
@mirpedrol mirpedrol merged commit c1acecd into dev Aug 31, 2022
@mirpedrol mirpedrol deleted the use-publish-action-release-v1 branch August 31, 2022 10:11
@ewels
Copy link
Member

ewels commented Aug 31, 2022

Nice, thanks @fabianegli !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PyPI Deployment GHA workflow
3 participants