Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalized code, better error message and link update #1812

Merged
merged 5 commits into from
Sep 8, 2022
Merged

generalized code, better error message and link update #1812

merged 5 commits into from
Sep 8, 2022

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Sep 6, 2022 •
edited
Loading

Closes #1809, #1803

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@fabianegli fabianegli requested a review from drpatelh September 6, 2022 12:32
@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited
Loading

Codecov Report

Merging #1812 (6db8862) into dev (148d9e2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1812   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          59       59           
  Lines        7148     7148           
=======================================
  Hits         4950     4950           
  Misses       2198     2198

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fabianegli added a commit to nf-core/quantms that referenced this pull request Sep 6, 2022
@fabianegli
surface conda channels check
6e2e5ad 
Upstream PR: nf-core/tools#1812
drpatelh
drpatelh reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 🚀 Can you update the CHANGELOG please? And maybe send a screenshot dump of what the logging would like here so I can take a look?

@fabianegli fabianegli force-pushed the better-conda-channel-priority-mismatch-message branch from 15de4ef to 7017caa Compare September 6, 2022 15:33
@fabianegli
Copy link
Contributor Author

fabianegli commented Sep 7, 2022 •
edited
Loading

New

From https://github.com/nf-core/quantms/runs/8222237897?check_suite_focus=true

Screenshot 2022-09-07 at 09 01 25

Old

From https://github.com/nf-core/quantms/runs/8186653746?check_suite_focus=true

Screenshot 2022-09-07 at 09 00 48

@fabianegli fabianegli requested a review from drpatelh September 7, 2022 07:51
drpatelh
drpatelh approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@fabianegli fabianegli merged commit 153300d into nf-core:dev Sep 8, 2022
@fabianegli fabianegli deleted the better-conda-channel-priority-mismatch-message branch September 8, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianegli @drpatelh