Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a context to temporarily change the working directory #1819

Conversation

fabianegli
Copy link
Contributor

Using contexts is safer because this way the working directory reset happens even if something unexpected happens between setting and resetting the working directory.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1819 (9aa0d91) into dev (153300d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1819   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          59       59           
  Lines        7148     7148           
=======================================
  Hits         4950     4950           
  Misses       2198     2198           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fabianegli fabianegli changed the title change to the working directory in a context Use a context to temporarily change the working directory Sep 8, 2022
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianegli
Copy link
Contributor Author

Tests are still missing.

@fabianegli fabianegli added the WIP Work in progress label Sep 11, 2022
@fabianegli fabianegli removed the WIP Work in progress label Sep 12, 2022
@fabianegli fabianegli merged commit 1bbc4f5 into nf-core:dev Sep 12, 2022
@fabianegli fabianegli deleted the use-context-when-changing-working-directory-in-tests branch September 12, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants