Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve template customisation documentation #1821

Merged
merged 6 commits into from
Oct 19, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Sep 8, 2022

Apply suggestions from #1804

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mirpedrol
Copy link
Member Author

@nf-core-bot fix linting

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1821 (8119253) into dev (19e0373) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1821   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files          37       37           
  Lines        4677     4677           
=======================================
  Hits         2858     2858           
  Misses       1819     1819           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol marked this pull request as ready for review September 8, 2022 10:30
README.md Outdated Show resolved Hide resolved
@mashehu mashehu mentioned this pull request Sep 20, 2022
4 tasks
ewels
ewels previously requested changes Sep 20, 2022
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also remove dashes from cool-pipes-company-coolpipe - even if it works, it makes the examples more confusing, as we separate prefix and repo name with a dash.

Might be a bit long, so probably better to replace it with myorg or something shorter.

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@apeltzer apeltzer requested a review from ewels September 21, 2022 07:09
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now :-) Thank you @mirpedrol

@mirpedrol
Copy link
Member Author

Thanks! I will need a ✅ from @ewels for the requested changes, or dismiss the review 😬

@apeltzer apeltzer merged commit b6be4ff into nf-core:dev Oct 19, 2022
@mirpedrol mirpedrol deleted the customisation-docs branch October 19, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants