Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip base.config when skipping nf-core/configs #1857

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Oct 3, 2022

Jinja templating was a little too aggressive when skipping nf-core/configs.

@ewels ewels requested a review from Midnighter October 3, 2022 09:06
Copy link
Contributor

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1857 (1182951) into dev (c2c4f54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1857   +/-   ##
=======================================
  Coverage   64.64%   64.64%           
=======================================
  Files          34       34           
  Lines        4115     4115           
=======================================
  Hits         2660     2660           
  Misses       1455     1455           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ewels ewels merged commit aca662e into nf-core:dev Oct 3, 2022
@ewels ewels deleted the bugfix-include-base-cong branch October 3, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants