Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_up_to_date() also checks for subworkflows #1934

Merged
merged 8 commits into from
Oct 12, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Oct 11, 2022

The check_up_to_date() function from modules_json.py also checks for subworkflows.
This also fixes the issue when installing a subworkflow from a new modules repo. To test:

nf-core create # Create a new test pipeline
nf-core subworkflows --git-remote https://gitlab.com/nf-core/modules-test.git --branch subworkflows install bam_sort_samtools # try installing a subworkflow from a new remote

close #1917

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

nf_core/modules/modules_json.py Outdated Show resolved Hide resolved
nf_core/modules/modules_json.py Outdated Show resolved Hide resolved
nf_core/modules/modules_json.py Outdated Show resolved Hide resolved
nf_core/modules/modules_json.py Outdated Show resolved Hide resolved
nf_core/subworkflows/install.py Outdated Show resolved Hide resolved
mirpedrol and others added 3 commits October 12, 2022 10:29
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1934 (a4b4645) into dev (865cae8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev    #1934   +/-   ##
=======================================
  Coverage   60.03%   60.04%           
=======================================
  Files          37       37           
  Lines        4642     4640    -2     
=======================================
- Hits         2787     2786    -1     
+ Misses       1855     1854    -1     
Impacted Files Coverage Δ
nf_core/subworkflows/install.py 14.50% <0.00%> (+0.21%) ⬆️
nf_core/modules/test_yml_builder.py 49.09% <0.00%> (-0.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol merged commit 5be0720 into nf-core:dev Oct 12, 2022
@mirpedrol mirpedrol deleted the checkuptodate branch October 12, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants