Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add versions.yml to create-test-yml but not md5sum #1963

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

mirpedrol
Copy link
Member

close #1958

The file versions.yml was removed from test.yml by mistake.
Add the check that the file exist back, but do not print the md5sum.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse maxulysse changed the title add vestions.yml to create-test-yml but not md5sum add versions.yml to create-test-yml but not md5sum Oct 24, 2022
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirpedrol
Copy link
Member Author

thanks!
omg this commit message, I can't type fast 🙈

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1963 (cbaecc2) into dev (5b8ed27) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1963      +/-   ##
==========================================
+ Coverage   61.10%   61.14%   +0.03%     
==========================================
  Files          37       37              
  Lines        4677     4676       -1     
==========================================
+ Hits         2858     2859       +1     
+ Misses       1819     1817       -2     
Impacted Files Coverage Δ
nf_core/modules/test_yml_builder.py 49.77% <100.00%> (+0.22%) ⬆️
nf_core/modules/lint/__init__.py 83.06% <0.00%> (+0.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-core modules create-test-yml does not check existence of versions.yml
3 participants