-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage of __main__.py
#1965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a quick look at it.
Codecov Report
@@ Coverage Diff @@
## dev #1965 +/- ##
==========================================
+ Coverage 61.13% 61.86% +0.72%
==========================================
Files 37 37
Lines 4678 4678
==========================================
+ Hits 2860 2894 +34
+ Misses 1818 1784 -34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f34944e
to
ca1dd21
Compare
Thanks for the comments, I think you can take another look now |
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
This PR adds unit test for the following commands:
list
,launch
,download
,create
andlint
.The code of these commands is quite simple so what the tests do is mostly check that no cli arguments are forgotten and that they are passed along to the correct function.
Related to #1937
PR checklist
CHANGELOG.md
is updated