-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor prettier invocation #1974
Refactor prettier invocation #1974
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1974 +/- ##
==========================================
- Coverage 62.01% 61.97% -0.04%
==========================================
Files 42 42
Lines 4862 4868 +6
==========================================
+ Hits 3015 3017 +2
- Misses 1847 1851 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Related to #1972
Could we maybe also include the bug fix mentioned in #1972 (comment) and we might need to update the documentation on the website, that |
@mashehu I just went to open a new PR for this off dev and it seems Julia actually fixed it in dev two weeks ago: |
Mostly a refactoring of the invocation of Prettier. Removes some code redundancy.
PR checklist
CHANGELOG.md
is updateddocs
is updated