Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prettier invocation #1974

Merged
merged 6 commits into from
Nov 2, 2022

Conversation

fabianegli
Copy link
Contributor

Mostly a refactoring of the invocation of Prettier. Removes some code redundancy.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #1974 (f173d90) into dev (6bf8f30) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##              dev    #1974      +/-   ##
==========================================
- Coverage   62.01%   61.97%   -0.04%     
==========================================
  Files          42       42              
  Lines        4862     4868       +6     
==========================================
+ Hits         3015     3017       +2     
- Misses       1847     1851       +4     
Impacted Files Coverage Δ
nf_core/lint_utils.py 77.77% <33.33%> (-8.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Related to #1972

nf_core/create.py Show resolved Hide resolved
@mashehu
Copy link
Contributor

mashehu commented Oct 27, 2022

Could we maybe also include the bug fix mentioned in #1972 (comment) and we might need to update the documentation on the website, that create requires prettier.

@awgymer
Copy link
Contributor

awgymer commented Oct 27, 2022

Could we maybe also include the bug fix mentioned in #1972 (comment) and we might need to update the documentation on the website, that create requires prettier.

@mashehu I just went to open a new PR for this off dev and it seems Julia actually fixed it in dev two weeks ago:
ff93650

@fabianegli fabianegli merged commit 5c0d98b into nf-core:dev Nov 2, 2022
@fabianegli fabianegli deleted the refactor-prettier-invocation branch November 15, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants