Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pre-commit run prettier if prettier is not available #1983

Merged
merged 26 commits into from
Nov 29, 2022
Merged

Use pre-commit run prettier if prettier is not available #1983

merged 26 commits into from
Nov 29, 2022

Commits on Oct 29, 2022

  1. use f-string instead of format

    @fabianegli
    fabianegli committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    fbb1759 View commit details
    Browse the repository at this point in the history

  2. use pre-commit installed Prettier if not already installed

    @fabianegli
    fabianegli committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    b1882d8 View commit details
    Browse the repository at this point in the history

  3. ship and use the nf-core pre-commit config for linting

    @fabianegli
    fabianegli committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    a9a9be9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Oct 29, 2022
    Configuration menu
    Copy the full SHA
    f77c935 View commit details
    Browse the repository at this point in the history

  5. fix typo in variable name

    @fabianegli
    fabianegli committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    5860858 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    0cca4ce View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. simplify conditions and utilize lazy eval 

    of elif
    @fabianegli
    fabianegli committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    1e46a5d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 5, 2022
    Configuration menu
    Copy the full SHA
    d46eec9 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. fix typo in variable name

    @fabianegli
    fabianegli committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    d648284 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. remove unused argument

    @fabianegli
    fabianegli committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d143da6 View commit details
    Browse the repository at this point in the history

  2. only compute fix flags if needed

    @fabianegli
    fabianegli committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    dcb8ac0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 7, 2022
    Configuration menu
    Copy the full SHA
    cd1b05d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    81b0ed2 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. make running prettier return better error messages

    @fabianegli
    fabianegli committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    9c95c5c View commit details
    Browse the repository at this point in the history

  2. add tests for prettier invocations

    @fabianegli
    fabianegli committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    22819d9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    d52d83d View commit details
    Browse the repository at this point in the history

  4. remove unused imports

    @fabianegli
    fabianegli committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    5f4711e View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b674a3b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    4ad7812 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6760188 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    1e76772 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    333c918 View commit details
    Browse the repository at this point in the history

  2. exclusiely run prettier from pre-commit hook

    @fabianegli
    fabianegli committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    fe1ca2b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    0d52e0d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    bb5ad2d View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Merge branch 'dev' into pre-commit-run-prettier

    @fabianegli
    fabianegli authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    0ec2d1e View commit details
    Browse the repository at this point in the history